Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross network favorites #1710

Closed
adamgall opened this issue May 8, 2024 · 4 comments · Fixed by #1975
Closed

Cross network favorites #1710

adamgall opened this issue May 8, 2024 · 4 comments · Fixed by #1975
Assignees

Comments

@adamgall
Copy link
Member

adamgall commented May 8, 2024

recording

Can we make favorites viewable across networks? Currently seeing no favorites if on a different network. Means we're asking users to manage multiple favorites lists.

Browser metadata
Path:      /home?dao=eth:0xD26c85D435F02DaB8B220cd4D2d398f6f646e235
Browser:   Firefox 125.0 on Mac OS 10.15
Viewport:  1402 x 912 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

Originally posted by @nicolaus-sherrill in #1578 (comment)

@adamgall adamgall added the re-skin Temporary Label for Reskin Work label May 8, 2024
@adamgall
Copy link
Member Author

adamgall commented May 8, 2024

I think this is outside of the scope of the reskin, but a good idea regardless. Will require more design and engineering brains to implement though.

@Da-Colon
Copy link
Contributor

Da-Colon commented May 8, 2024

yep not to bad actually. You've set up the ground work with the new query. and wouldn't be much to sort and reorg the list into a object by network. then just add a label between each section? We have the patterns for 'labels' with the Wallet Menu so could be a easy win.

@Da-Colon Da-Colon added design Design team's responsibility help-needed More Investigation needed labels May 9, 2024
@nicolaus-sherrill
Copy link

Word!

To @Da-Colon 's point, two quick solutions:

  1. Add network icon to Favorite list item
  2. Segment list by network

Even though we're going to be removing the DAO index from the home page, this same functionality is intended there too. User should be able to view DAOs across chains & possibly filter down (let's us display more DAOs in the index at once = better look for BD).

@adamgall adamgall removed the re-skin Temporary Label for Reskin Work label May 9, 2024
@Da-Colon Da-Colon self-assigned this Jun 3, 2024
@Da-Colon Da-Colon removed design Design team's responsibility help-needed More Investigation needed labels Jun 5, 2024
@adamgall
Copy link
Member Author

This is completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants