Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare edit hats proposal #2064

Merged
merged 44 commits into from
Jul 4, 2024
Merged

Conversation

DarksightKellar
Copy link
Contributor

@DarksightKellar DarksightKellar commented Jul 2, 2024

This PR implements a set of functions that together prepare and submit a proposal to make updates to Roles on a Decent Safe.

Two possible proposals might be prepared depending on the state of the Safe at the time of edit:

  • The safe has never previously used the Roles feature. The proposal will be to:

    • Add the DecentHatsContract as a module to the safe
    • Call createAndDeclareTree on DecentHatsContract. This creates the top hat, admin hat, and any added hats
    • Remove the DecentHatsContract module from the safe
  • The safe already has a top hat. The proposal will be to:

    • Commit any edits the Safe user made to the roles on their safe, including
    • added hats
    • hats wearer changed
    • removed hats
    • hat details changed

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit b236c90
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/6686f88dc9d7950008ac9a10
😎 Deploy Preview https://deploy-preview-2064.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DarksightKellar DarksightKellar changed the title Prepare-edit-hat-proposal [WIP] Prepare-edit-hat-proposal Jul 2, 2024
@adamgall adamgall force-pushed the prepare-edit-hat-proposal branch 2 times, most recently from eb1471e to e89c914 Compare July 3, 2024 00:12
@DarksightKellar DarksightKellar changed the title [WIP] Prepare-edit-hat-proposal Prepare edit hats proposal Jul 4, 2024
@DarksightKellar DarksightKellar marked this pull request as ready for review July 4, 2024 16:22
@Da-Colon Da-Colon merged commit 4e38c91 into issue/2049-add-form Jul 4, 2024
7 checks passed
@Da-Colon Da-Colon deleted the prepare-edit-hat-proposal branch July 4, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants