-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare edit hats proposal #2064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DarksightKellar
changed the title
Prepare-edit-hat-proposal
[WIP] Prepare-edit-hat-proposal
Jul 2, 2024
adamgall
force-pushed
the
prepare-edit-hat-proposal
branch
2 times, most recently
from
July 3, 2024 00:12
eb1471e
to
e89c914
Compare
DarksightKellar
changed the title
[WIP] Prepare-edit-hat-proposal
Prepare edit hats proposal
Jul 4, 2024
…nt-interface into prepare-edit-hat-proposal
Da-Colon
force-pushed
the
prepare-edit-hat-proposal
branch
from
July 4, 2024 19:31
d0ee6c9
to
b236c90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a set of functions that together prepare and submit a proposal to make updates to Roles on a Decent Safe.
Two possible proposals might be prepared depending on the state of the Safe at the time of edit:
The safe has never previously used the Roles feature. The proposal will be to:
createAndDeclareTree
on DecentHatsContract. This creates the top hat, admin hat, and any added hatsThe safe already has a top hat. The proposal will be to: