Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot-fix navigating to subDAO from hierarchy page when parent DAO has large amount of subDAOs #2078

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

mudrila
Copy link
Contributor

@mudrila mudrila commented Jul 4, 2024

  • Prevent setting readOnlyValues if they haven't changed
  • Prevent setting canUserSubmitProposal if that value hasn't changed

For testing - try to visit 0x374D5a17D2433415C48C735A493F0523DaB99041 DAO's hierarchy page on Base

The actual problem is connected to rate limits and requests failure, which causes infinitely reiterate callbacks in useEffect

@mudrila mudrila added the bug Something isn't working label Jul 4, 2024
@mudrila mudrila self-assigned this Jul 4, 2024
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for decent-interface-prod ready!

Name Link
🔨 Latest commit 00b6569
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-prod/deploys/668727b709b7fa0008812909
😎 Deploy Preview https://deploy-preview-2078.app.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 846b404
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/66880721e16e5b0008da84cb
😎 Deploy Preview https://deploy-preview-2078.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomstuart123
Copy link

Approved as clicked through to multiple subDAOs from both Myosin and Shutter's parent Safes

@adamgall adamgall changed the base branch from main to develop July 5, 2024 14:44
@adamgall adamgall merged commit 56a139a into develop Jul 5, 2024
7 checks passed
@adamgall adamgall deleted the hotfix/infinity-loops-on-large-hierarchy branch July 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants