Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Base Sepolia #2080

Merged
merged 3 commits into from
Jul 8, 2024
Merged

No Base Sepolia #2080

merged 3 commits into from
Jul 8, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented Jul 5, 2024

No more Base Sepolia

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 5366892
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/6688e0cab040990008f84881
😎 Deploy Preview https://deploy-preview-2080.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mudrila mudrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -18,8 +18,6 @@ VITE_APP_ALCHEMY_MAINNET_API_KEY=""
VITE_APP_ALCHEMY_POLYGON_API_KEY=""
# Alchemy provider API key, used on Sepolia
VITE_APP_ALCHEMY_SEPOLIA_API_KEY=""
# Alchemy provider API key, used on Base Sepolia
VITE_APP_ALCHEMY_BASE_SEPOLIA_API_KEY=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk can we automate and make dynamic all this shit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually yes we can, but only recently. Alchemy (as of only recently) now lets you use the same API key for all networks! I'll clean this up in a future PR.

@adamgall adamgall merged commit 91ee3a9 into develop Jul 8, 2024
7 checks passed
@adamgall adamgall deleted the no-base-sepolia branch July 8, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants