Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "Coming soon" Tooltip for Sablier functionality #2106

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Show "Coming soon" Tooltip for Sablier functionality #2106

merged 2 commits into from
Jul 9, 2024

Conversation

DarksightKellar
Copy link
Contributor

@DarksightKellar DarksightKellar commented Jul 9, 2024 •
edited
Loading

Closes #2089

Screenshot 2024-07-09 at 13 38 59 Screenshot 2024-07-09 at 13 39 12

@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024 •
edited
Loading

✅ Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 3928e6f
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/668d3b5b650c5a0008033843
😎 Deploy Preview https://deploy-preview-2106.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DarksightKellar DarksightKellar requested review from a team July 9, 2024 12:40
adamgall
adamgall requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the tooltip appear when hovering over any part of the tab, not just the tab's text label.

@DarksightKellar
Copy link
Contributor Author

Please make the tooltip appear when hovering over any part of the tab, not just the tab's text label.

@adamgall this was trickier than normal because of Portal magic. Implementation is hacky, and there's a few pixels around the tab that don't register

adamgall
adamgall approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeesh this apparently wasn't as easy of a request as I thought it would be

@adamgall adamgall merged commit 3783d3b into roles-0.1.1/desktop-and-other-updates Jul 9, 2024
7 checks passed
@adamgall adamgall deleted the 2089-sablier-coming-soon-tooltip branch July 9, 2024 13:41
@adamgall adamgall mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgall adamgall adamgall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarksightKellar @adamgall