Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2128 ensure Role Info form validates correctly #2133

Merged
merged 2 commits into from
Jul 11, 2024
Merged

2128 ensure Role Info form validates correctly #2133

merged 2 commits into from
Jul 11, 2024

Conversation

Da-Colon
Copy link
Contributor

Fixes #2128

@Da-Colon Da-Colon self-assigned this Jul 11, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 11, 2024 •
edited
Loading

✅ Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit fab4cf3
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/668fee6b044aa0000878764d
😎 Deploy Preview https://deploy-preview-2133.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DarksightKellar
DarksightKellar approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@DarksightKellar DarksightKellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

adamgall
adamgall approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving an approval, but curious about what type meta.error is because why not just do errorMessage={meta.error}?

src/components/pages/Roles/forms/RoleFormInfo.tsx Outdated Show resolved Hide resolved
@adamgall adamgall merged commit 0a62463 into develop Jul 11, 2024
7 checks passed
@adamgall adamgall deleted the issue/2128-roleinfo-validation-fix branch July 11, 2024 15:37
@adamgall adamgall mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgall adamgall adamgall approved these changes

@DarksightKellar DarksightKellar DarksightKellar approved these changes

@mudrila mudrila Awaiting requested review from mudrila

Assignees

@Da-Colon Da-Colon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Role form validation not working
3 participants
@Da-Colon @adamgall @DarksightKellar