Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2139 Clean up Create Role Proposal UI #2140

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Da-Colon
Copy link
Contributor

@Da-Colon Da-Colon commented Jul 11, 2024

Remove Grid component and adjust width to properly size screen

localhost_3000_roles_edit_summary_dao=sep_0xd6Cb633E3A9cDEbA8a7A5CA4F30436F10FEbd418(Desktop)

Fixes #2139

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit e0f453a
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/669020016932aa00088ccb68
😎 Deploy Preview https://deploy-preview-2140.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall
Copy link
Member

@Da-Colon what are the changes here?

@Da-Colon
Copy link
Contributor Author

@Da-Colon what are the changes here?

So when opening on desktop this screen width was going past the width of the screen causing not only header line to go off screen but also the horizontal scroll to appear. It was setup to be a Grid for a two-column setup but currently isn't going to be implemented that way.

@tomstuart123
Copy link

@Da-Colon sorry to jump in but @adamgall and I just discussed this page. It still feels a little far to the left (horizontally) and a little less padding (vertically) than would be ideal

At the same time, @adamgall it seems like this PR fixes the original issue so shall we review and merge this and then create a new issue just for this page (probably to be implemented once sablier is done)

Wdyt both think?

@adamgall
Copy link
Member

Confirmed with @Da-Colon and @tomstuart123 to merge this as-is

@adamgall adamgall merged commit 3883391 into develop Jul 12, 2024
7 checks passed
@adamgall adamgall deleted the issue/2139-cleanup-create-proposal-ui branch July 12, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[roles-0.1.0] Clean up Create proposal UI
3 participants