2092 Add payroll form UI

[Da-Colon]

Closes #2092

Notes

• UI only, though it is hooked up to the form ✅
• Frequency, Frequency Amount, Asset Selector Implemented and connected to form, with some error handling ✅
• Date Picker Not implemented ❌
• Error Handling for payroll + roleInfo not fully implemented ❌
• "Has Updated" Logic not implemented ❌ for payroll
• Need @decentdao/design help (mentioned in standup, haven't looked in designs as of writing this for updates)
  • Tooltips around sections
  • External Links "Learn More" links

Other callouts

• @decentdao/design The Drawer for Asset background is different from the 'frequency' selection, intentional?
• @decentdao/engineering You'll notice the hardcoded values. because this is a menu, I was unable to use % values. I tried for a while different ways to be more responsive, I submit that I failed and maybe we kick this bucket down the road. as they look fine I think for most screens
  Desktop
  

Mobile

[netlify]

✅ Deploy Preview for decent-interface-dev ready!

Name	Link
🔨 Latest commit
🔍 Latest deploy log	https://app.netlify.com/sites/decent-interface-dev/deploys/6697382c4901e633dd54ba9b
😎 Deploy Preview	https://deploy-preview-2149.app.dev.decentdao.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[tomstuart123]

Looks sick @Da-Colon

To confirm, is the 'select asset' meant to be functional with what assets are in the treasury? Reason I ask is I don't see any assets appearing on mine (see screenshot) despite holding a token called $BUG. If that is intended behaviour, it could be because my treasury page is erroring again in this PR (not in production) so that could be the cause

Another smaller thing, the drop down for 'frequency' drops downwards in mobile view but upwards in desktop view. See below

[Da-Colon]

Looks sick @Da-Colon

To confirm, is the 'select asset' meant to be functional with what assets are in the treasury? Reason I ask is I don't see any assets appearing on mine (see screenshot) despite holding a token called $BUG. If that is intended behaviour, it could be because my treasury page is erroring again in this PR (not in production) so that could be the cause

Another smaller thing, the drop down for 'frequency' drops downwards in mobile view but upwards in desktop view. See below

Weird, Bug shows up for me

[Da-Colon]

Looks sick @Da-Colon

To confirm, is the 'select asset' meant to be functional with what assets are in the treasury? Reason I ask is I don't see any assets appearing on mine (see screenshot) despite holding a token called $BUG. If that is intended behaviour, it could be because my treasury page is erroring again in this PR (not in production) so that could be the cause

Another smaller thing, the drop down for 'frequency' drops downwards in mobile view but upwards in desktop view. See below

As far as the Mobile drawer opening down. This happens automatically based on the space on mobile. if there isn't enough viewing space it will open going up. Doesn't appear I can change that behavior.

[tomstuart123]

@Da-Colon - hmmm. Have no idea why but my asset still isn't appearing.

@nicolaus-sherrill / @xraystyle1980 could one of you check? See comments above for context and the DAO in question here - https://deploy-preview-2149.app.dev.decentdao.org/roles/edit/details?dao=sep:0xB748f1a172C624cA088F3cD87D8A2139bA30df1d&hatId=0x5f02026fe45f68c1bcfbecb8dfa9867c4ecb2f1fa76d474dd3b4c6423d6a36bc

[Da-Colon]

@Da-Colon - hmmm. Have no idea why but my asset still isn't appearing.

@nicolaus-sherrill / @xraystyle1980 could one of you check? See comments above for context and the DAO in question here - https://deploy-preview-2149.app.dev.decentdao.org/roles/edit/details?dao=sep:0xB748f1a172C624cA088F3cD87D8A2139bA30df1d&hatId=0x5f02026fe45f68c1bcfbecb8dfa9867c4ecb2f1fa76d474dd3b4c6423d6a36bc

Pretty sure I was looking at the deploy-preview before, but its not showing up for me now either. @mudrila The Moralis (Netlify/Function) network call isn't returning any data on the deploy preview.

[adamgall]

Probably because our dev Moralis plan runs out of “credits” or whatever by like 9 or 10 am every day, until the next day. Maybe we can sub in the prod moralis keys on dev. That’ll very likely fix these issues we’re seeing on dev and deploy previews regarding assets not appearing. I did like the pattern of separating all third party services into “dev” and “prod” scoped keys, but meh it’s probably fine if we just use a single Moralis plan for dev and prod. David / Kirill / Kelvin feel free to copy the Moralis keys from Netlify prod into Netlify dev

…

On Tue, Jul 16, 2024 at 7:02 PM David Colon ***@***.***> wrote: @Da-Colon <https://github.com/Da-Colon> - hmmm. Have no idea why but my asset still isn't appearing. @nicolaus-sherrill <https://github.com/nicolaus-sherrill> / @xraystyle1980 <https://github.com/xraystyle1980> could one of you check? See comments above for context and the DAO in question here - https://deploy-preview-2149.app.dev.decentdao.org/roles/edit/details?dao=sep:0xB748f1a172C624cA088F3cD87D8A2139bA30df1d&hatId=0x5f02026fe45f68c1bcfbecb8dfa9867c4ecb2f1fa76d474dd3b4c6423d6a36bc Pretty sure I was looking at the deploy-preview before, but its not showing up for me now either. @mudrila <https://github.com/mudrila> The Moralis (Netlify/Function) network call isn't returning any data on the deploy preview. — Reply to this email directly, view it on GitHub <#2149 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFMS4KT2JGJCGVEQWRR4K3ZMWRAHAVCNFSM6AAAAABK5TNXUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRHE2TKOBRGE> . You are receiving this because you are on a team that was mentioned.Message ID: ***@***.***>

[Da-Colon]

Probably because our dev Moralis plan runs out of “credits” or whatever by like 9 or 10 am every day, until the next day. Maybe we can sub in the prod moralis keys on dev. That’ll very likely fix these issues we’re seeing on dev and deploy previews regarding assets not appearing. I did like the pattern of separating all third party services into “dev” and “prod” scoped keys, but meh it’s probably fine if we just use a single Moralis plan for dev and prod. David / Kirill / Kelvin feel free to copy the Moralis keys from Netlify prod into Netlify dev
…
On Tue, Jul 16, 2024 at 7:02 PM David Colon @.> wrote: @Da-Colon https://github.com/Da-Colon - hmmm. Have no idea why but my asset still isn't appearing. @nicolaus-sherrill https://github.com/nicolaus-sherrill / @xraystyle1980 https://github.com/xraystyle1980 could one of you check? See comments above for context and the DAO in question here - https://deploy-preview-2149.app.dev.decentdao.org/roles/edit/details?dao=sep:0xB748f1a172C624cA088F3cD87D8A2139bA30df1d&hatId=0x5f02026fe45f68c1bcfbecb8dfa9867c4ecb2f1fa76d474dd3b4c6423d6a36bc Pretty sure I was looking at the deploy-preview before, but its not showing up for me now either. @mudrila https://github.com/mudrila The Moralis (Netlify/Function) network call isn't returning any data on the deploy preview. — Reply to this email directly, view it on GitHub <#2149 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMS4KT2JGJCGVEQWRR4K3ZMWRAHAVCNFSM6AAAAABK5TNXUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRHE2TKOBRGE . You are receiving this because you are on a team that was mentioned.Message ID: @.>

Updated keys on netlify, and redeployed @tomstuart123 Just opened your link and its showing your token again.

[tomstuart123]

nice, this now works. Approved

[tomstuart123]

@decentdao/engineering - could one of you review and approve also

UPDATE - ignore above. Synced with Kelvin and he'll pick up the ❌'s above first