-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[roles-0.2.0/streams]
- Now the payroll is getting real baby
#2156
[roles-0.2.0/streams]
- Now the payroll is getting real baby
#2156
Conversation
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Awesome @mudrila so good seeing this all linking up. Primary feedback on logic/tests:
Note @decentdao/engineering could someone also double check my thinking for why I think the last bullet point is a ✅ --> 0xfC5Fd67C8C9e478D029827175230BEB883Bb9c09 this appears to be the hataccount for hatID '10460459718236864672367699073269748130132045948045810886507630648360960' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mudrila approving this for now as all the logic seems to be working :). Great job
Note @decentdao/design / @decentdao/engineering - I do have a number of product/design feedback that I'm logging and will write up in the root 'streams' PR pre we deploy to dev
For now though, lets just keep heads down.
Discussion at standup to merge now. @mudrila can you merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good. Minor comments but approving anyway in lieu of standup decision to move things forward
This PR adds ability to add a payroll stream to an existing hat or newly added hat when tree is present
That means it will only work when roles were added before!
Testing: