-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar Updates! #2169
Calendar Updates! #2169
Conversation
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Uau @DarksightKellar this looks so good!!! |
@DarksightKellar is it possible to make the day item selector pink background a bit more square instead of rectangular? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI is looking sharp so far @DarksightKellar. Great work.
Couple of small things:
- Square up the selected date. Currently rectangular.
- On desktop, align the pop-out component with the left side of the date input fields.
Thanks @DarksightKellar . I had some issues with the date picker when first opened but haven't been able to replicate it since then. Won't approve yet as design had raises above but will approve once reverted :) |
@xanaramoss The line breaking inputs were due to a sheer lack of horizontal space on smaller width screens. We've worked out a good middle ground (shoutout to @Da-Colon for working his grid magic): Regarding "active state on the end date field", I'm not sure what the ask is there, and I don't yet see any design updates. Could you elaborate, please? |
@nicolaus-sherrill Both points should be addressed now. Have another look when you get the chance =) |
@DarksightKellar Yesterday during a screenshare of this feature on standup (which I didn't call out in the moment), I saw that it was possible to set the End Date to a date before the Start Date, which I don't think should be possible. Can you confirm that I'm not just making this up? edit: this was actually during a screenshare with Hats team |
@adamgall if I remember my test two days ago, it is possible to click the end date before the start date. However, all that will happen is the start date will revert to that click and you'll still be forced to re-click an end date. I didn't hate that UX so I didn't raise it. I'll bring back up the netflify during standup to confirm |
@tomstuart123 has confirmed that i'm full of shit |
@nicolaus-sherrill your re-review on this plz 🥹 |
This PR implements a couple missing/buggy features on the original date picker implementation. There's no open issue for this.