Refactor streams creation into batching them by asset #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
changed the base branch from
roles-0.2.0/streams
to
roles-0.2.0/asset-drawer
adamgall
approved these changes
Aug 14, 2024
mudrila
force-pushed
the
roles-0.2.0/batch-streams-creation-into-single-transaction
branch
from
bac5378
to
9e96284
Compare
mudrila
force-pushed
the
roles-0.2.0/batch-streams-creation-into-single-transaction
branch
from
9e96284
to
1cf5c3a
Compare
mudrila
deleted the
roles-0.2.0/batch-streams-creation-into-single-transaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages batched stream creation and assembled multiple token approvals and linear stream creations into single pair of transaction, which are grouped by token address.
Since this branch is based off
roles-0.2.0/asset-drawer(in order to avoid conflicts with dev build crash fix) - strongly advise to review #2238 first