Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update payment columns #2241

Merged

Conversation

DarksightKellar
Copy link
Contributor

@DarksightKellar DarksightKellar commented Aug 14, 2024

Closes #2229
Closes #2232

Replaces payments column with Active Payments and their counts

Figma:
Screenshot 2024-08-14 at 16 44 45

App:
Screenshot 2024-08-14 at 16 42 35

Screenshot 2024-08-14 at 16 43 47

EDIT: Just realising the "no payments" look doesn't match figma. Will update.

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 5017eca
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/66be56f4c1d2400008d4665d
😎 Deploy Preview https://deploy-preview-2241.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall
Copy link
Member

@DarksightKellar can you please include some screenshots and descriptions of the visual changes in this PR?

@adamgall adamgall changed the title Issue/2232 update payment col Update payment columns Aug 14, 2024
@mudrila mudrila added the enhancement New feature or request label Aug 14, 2024
Copy link

@xraystyle1980 xraystyle1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desktop request:

  • Please nudge the active payments column so that it sits at the right edge of the table and center align the counter beneath the column header
    image

@nicolaus-sherrill
Copy link

Thanks @xraystyle1980
+1 that request

Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, code wise.

Copy link

@xraystyle1980 xraystyle1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the update after I create a role and the payment column is empty. That looks good.

However I want to see the pattern in action WITH a payment but I am unable to add payment to this role. See attached video

CleanShot.-.Arc.-.2024-08-15.mp4

@adamgall
Copy link
Member

@xraystyle1980 thanks for the bug report and video.

@DarksightKellar please look into this

Base automatically changed from issue/2228-handoff-form-updates to roles-0.2.0/streams August 15, 2024 17:37
@mudrila mudrila changed the base branch from roles-0.2.0/streams to issue/2230-handoff-role-details August 15, 2024 18:00
Copy link
Contributor

@mudrila mudrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments, otherwise - looks good
I also changed base branch to cut off amount of changes to what's actually changed

src/components/pages/Roles/RoleCard.tsx Show resolved Hide resolved
src/components/pages/Roles/RolePaymentDetails.tsx Outdated Show resolved Hide resolved
src/components/pages/Roles/RolesTable.tsx Outdated Show resolved Hide resolved
src/components/pages/Roles/RolesTable.tsx Outdated Show resolved Hide resolved
Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, assuming @mudrila's comments are addressed

@mudrila
Copy link
Contributor

mudrila commented Aug 15, 2024

@nicolaus-sherrill @xraystyle1980 Think I've tackled it.
I'm gonna merge this now assuming it was only design feedback
Yet, there's a need to test this pattern in action, which will be possible after merging currently opened PRs - so please take a note to check it during bug bash

@mudrila mudrila merged commit 7245ac3 into issue/2230-handoff-role-details Aug 15, 2024
7 checks passed
@mudrila mudrila deleted the issue/2232-update-payment-col branch August 15, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants