Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix | EditStreams #2321

Merged
merged 8 commits into from
Sep 3, 2024
Merged

Bugfix | EditStreams #2321

merged 8 commits into from
Sep 3, 2024

Conversation

Da-Colon
Copy link
Contributor

Found the issues with the Edit Stream workflow. Looks like code got duplicated in a merge fix and the wrong address was being passed into the encodeFunctionData function for flushing the stream.

@Da-Colon Da-Colon added the bug Something isn't working label Aug 29, 2024
@Da-Colon Da-Colon self-assigned this Aug 29, 2024
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 56be4ec
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/66d756b603a8770008759023
😎 Deploy Preview https://deploy-preview-2321.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Da-Colon Da-Colon marked this pull request as draft August 29, 2024 03:27
@adamgall adamgall marked this pull request as ready for review September 3, 2024 18:42
Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is good to go from my end. There is another branch coming soon which rewrites a bunch of this anyway.

Copy link
Contributor Author

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@adamgall adamgall merged commit b2fc2ec into develop Sep 3, 2024
7 checks passed
@adamgall adamgall deleted the bugfix-edit-streams branch September 3, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants