Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add send assets action to roles proposal #2351

Merged
merged 29 commits into from
Sep 20, 2024
Merged

Add send assets action to roles proposal #2351

merged 29 commits into from
Sep 20, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented Sep 16, 2024 •
edited
Loading

Closes #2353

@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 8373751
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/66ec3efd86e3f40008a37a29
😎 Deploy Preview https://deploy-preview-2351.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall force-pushed the add-send-assets-action-to-roles-proposal branch from 921c55d to 0b68896 Compare September 17, 2024 18:58
@adamgall adamgall marked this pull request as ready for review September 18, 2024 13:18
@adamgall adamgall self-assigned this Sep 18, 2024
nicolaus-sherrill
nicolaus-sherrill approved these changes Sep 18, 2024
View reviewed changes
Copy link

@nicolaus-sherrill nicolaus-sherrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Simply lovely.

@DarksightKellar
Copy link
Contributor

@adamgall Just tested the UI, looks sweet. I noticed there's no "disabled" look for these action buttons:
Screenshot 2024-09-19 at 13 47 22

I had to look at the code before I realised I was trying to test on a safe without any balance on a fungible asset

@adamgall
Copy link
Member Author

@adamgall Just tested the UI, looks sweet. I noticed there's no "disabled" look for these action buttons: Screenshot 2024-09-19 at 13 47 22

I had to look at the code before I realised I was trying to test on a safe without any balance on a fungible asset

Good find, will fix

@adamgall
Copy link
Member Author

@DarksightKellar i've fixed the things, plz review again.

DarksightKellar
DarksightKellar approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@DarksightKellar DarksightKellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Da-Colon
Da-Colon approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approved, functionally tested

@adamgall adamgall merged commit 5687807 into develop Sep 20, 2024
7 checks passed
@adamgall adamgall deleted the add-send-assets-action-to-roles-proposal branch September 20, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarksightKellar DarksightKellar DarksightKellar approved these changes

@Da-Colon Da-Colon Da-Colon approved these changes

@nicolaus-sherrill nicolaus-sherrill nicolaus-sherrill approved these changes

@mudrila mudrila Awaiting requested review from mudrila

@parkermccurley parkermccurley Awaiting requested review from parkermccurley

@xanaramoss xanaramoss Awaiting requested review from xanaramoss

Assignees

@adamgall adamgall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Send Assets" actions to be added to Roles proposals
4 participants
@adamgall @DarksightKellar @Da-Colon @nicolaus-sherrill