-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix address input field validation #2360
Conversation
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
there are still some issues with this code... Here's what I'm experiencing:
|
that is weird. I'll look into it |
Just attempted a few times not getting htat behavior |
Hmmmmm really? I'm consistently reproducing it on my side. Screenshare? |
Seems like a Frame issue, not gonna worry about it. |
fixes #2355
The only sucky thing here is that it requires the user to click out of the address input field in order for the validation to work. Spoke with @Da-Colon about potential alternative approaches to "fix" this, but I don't want to put more time into it.
To test (and compare behavior between dev/prod and this PR)
The behavior should be more "consistent" on this branch. Behavior meaning, input validation and the "create proposal" button becoming enabled.