Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source map parsing error when used with create-react-app #23

Closed
hydrandt opened this issue Dec 27, 2021 · 2 comments · Fixed by #24
Closed

Source map parsing error when used with create-react-app #23

hydrandt opened this issue Dec 27, 2021 · 2 comments · Fixed by #24
Assignees

Comments

@hydrandt
Copy link

In last version of react-scripts, warnings are now being shown for problems with parsing source maps in dependencies. As a result, with every run of react-scripts, there is a warning:

WARNING in ./node_modules/@demvsystems/yup-ast/dist/index.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/hydrandt/ark/ark-react-frontend/frontend/node_modules/@demvsystems/yup-ast/src/index.ts' file: Error: ENOENT: no such file or directory, open '/home/hydrandt/ark/ark-react-frontend/frontend/node_modules/@demvsystems/yup-ast/src/index.ts'

There is a MR in react-scripts about disabling these warnings:

facebook/create-react-app#11752

Still I thought it may be worth reporting.

@kassuro
Copy link
Contributor

kassuro commented Dec 28, 2021

Thanks for submitting the issue.
We will look into this after the holidays in January.

@kassuro
Copy link
Contributor

kassuro commented Jan 7, 2022

Hey, so we checked this out and the warning is totally correct. Since we didn't include our sources in the package the source map referenced a file that does not exist in the package.

After some research we decided we include the source files in the package as you can see in #24 .

I have tested this locally already with CRA and didn't get any warnings for yup-ast 👍

@kassuro kassuro self-assigned this Jan 7, 2022
@kassuro kassuro linked a pull request Jan 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants