Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions for 'deno test' print errors in zsh #13702

Closed
rherrmann opened this issue Feb 17, 2022 · 11 comments
Closed

Completions for 'deno test' print errors in zsh #13702

rherrmann opened this issue Feb 17, 2022 · 11 comments
Labels
bug Something isn't working correctly upstream Changes in upstream are required to solve these issues

Comments

@rherrmann
Copy link

I'm using Oh-My-Zsh and installed Deno with Hombrew. It puts completions in /usr/local/share/zsh/site-functions.

While completions work fine in general, typing deno test <TAB> prints this:

_arguments:comparguments:325: doubled rest argument definition: *::script_arg -- Script arg:
_arguments:comparguments:325: doubled rest argument definition: *::script_arg -- Script arg:
_arguments:comparguments:325: doubled rest argument definition: *::script_arg -- Script arg:

Observed with version 1.18.2 and 1.19.

@crowlKats crowlKats added the upstream Changes in upstream are required to solve these issues label Feb 17, 2022
@crowlKats
Copy link
Member

Ref clap-rs/clap#3022

@crowlKats crowlKats added the bug Something isn't working correctly label Feb 17, 2022
@mcornella
Copy link

This happens in vanilla zsh. Using Oh My Zsh is irrelevant.

@jsejcksn
Copy link
Contributor

jsejcksn commented Mar 7, 2022

This happens in vanilla zsh. Using Oh My Zsh is irrelevant.

@rherrmann This is accurate. The issue title can be changed to reflect the larger scope: zsh in general.

@rherrmann rherrmann changed the title Completions for 'deno test' print errors on Oh-My-Zsh Completions for 'deno test' print errors in zsh Mar 7, 2022
@jespertheend
Copy link
Contributor

Seems like a workaround for now is to manually remove the *::script_arg part in your completions file.

'--quiet[Suppress diagnostic output]' \
'*::files -- List of file names to run:_files' \
- '*::script_arg -- Script arg:_files' \

You can also change it to how it was in 1.17.3 and simply remove the asterisks before *::files and *::script_arg.

@sant123
Copy link

sant123 commented May 24, 2022

I'm currently using Oh My Zsh in Deno v1.22.0 and it prints the errors:

image

@tohsaka888
Copy link

same error occured in arch linux, any solution?

@crowlKats
Copy link
Member

@tohsaka888 what Deno version are you on?

@tohsaka888
Copy link

@crowlKats
image

@sant123
Copy link

sant123 commented Jan 10, 2023

I'm having the same issue.

deno 1.29.2 (release, x86_64-unknown-linux-gnu)
v8 10.9.194.5
typescript 4.9.4
fedora 36

@zuisong
Copy link
Contributor

zuisong commented Jan 11, 2023

Seems like a workaround for now is to manually remove the *::script_arg part in your completions file.

'--quiet[Suppress diagnostic output]' \
'*::files -- List of file names to run:_files' \
- '*::script_arg -- Script arg:_files' \

You can also change it to how it was in 1.17.3 and simply remove the asterisks before *::files and *::script_arg.

It works for me , tks

deno 1.29.2 (release, aarch64-apple-darwin)
v8 10.9.194.5
typescript 4.9.4

@crowlKats
Copy link
Member

Closing as this seems to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly upstream Changes in upstream are required to solve these issues
Projects
None yet
Development

No branches or pull requests

8 participants