Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flag for excluding popeye codes on reports #144

Open
peddyhh opened this issue Nov 5, 2020 · 8 comments
Open

flag for excluding popeye codes on reports #144

peddyhh opened this issue Nov 5, 2020 · 8 comments
Labels
question Further information is requested

Comments

@peddyhh
Copy link

peddyhh commented Nov 5, 2020




Is your feature request related to a problem? Please describe.
When I using popey like "popeye -l warn", I got the warning messages
"[POP-300] Using "default" ServiceAccount"
This is not an issue, this is intended.

Describe the solution you'd like
I want a flag, called "--exclude". It should be possible, to use a list t of "POP-XXX" Codes as parameter.
For example
"popeye -l warn --exclude POP-300,POP-403"

@peddyhh peddyhh changed the title flag for excluding popeye codes flag for excluding popeye codes on reports Nov 5, 2020
@howardjones
Copy link

I would also like this. Especially for POP-300 and POP-400. Popeye does not appear to consider envFrom to be a "use" of a ConfigMap entry.

@derailed derailed added the question Further information is requested label Dec 5, 2020
@derailed
Copy link
Owner

derailed commented Dec 5, 2020

@peddyhh @howardjones Thank you both for reporting this. You can use a spinach.yml file to exclude the codes that you know are legit.

@howardjones EnvFrom is checked if that's no what you're seeing, please add more details here. Tx!!

@peddyhh
Copy link
Author

peddyhh commented Feb 1, 2021

In CD- or CS-Pipelines I don't want to use an extra spinach.yaml file.
Sometimes it is not even possible to have an extra spinach.yaml file.

I would appreciate it a lot.

@danibaeyens
Copy link
Contributor

What about checking an annotation in certain resources?
In my use case, I run a multi-tenant cluster with different teams split by namespaces. I run a central prometheus which gets metrics from the different namespaces (I run popeye once per namespace), so teams can see their scores in grafana.

At the end, I'm the owner of popeye and it can be really cumbersome to update the spinach files to allow certain rules under team requests, but it would be much effective if every team can annotate every resource they'd like to skip.

@derailed Would you accept an addition like that one?

@danibaeyens
Copy link
Contributor

OMG, I already did the suggestion at #160 ! Sorry about duplicating! I'll try to propose something, then :)

@derailed
Copy link
Owner

@danibaeyens lol - nw I thought this sounded familiar... Yes I think annotations make sense. Pb here you do loose control as some teams may elect for less restrictive measures about their spinach configurations and thus yield a seemingly higher scores while masking underlying issues??

@howardjones
Copy link

Should lots of 'ignore' annotations earn you a penalty? :-)

@danibaeyens
Copy link
Contributor

@derailed absolutely. Great power comes with great responsibility

@howardjones Yes! I thought about assing that as well. Maybe every "skipping" annotation triggers a info rule (which severity can be overridden by the spinach file if needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants