Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTORING] shontzu/TRAH-3015/ui-for-seamless-MT5-mobile-login-integration #111

Merged
merged 12 commits into from
Apr 22, 2024
Merged

[REFACTORING] shontzu/TRAH-3015/ui-for-seamless-MT5-mobile-login-integration #111

merged 12 commits into from
Apr 22, 2024

Conversation

shontzu-deriv
Copy link
Contributor

@shontzu-deriv shontzu-deriv commented Apr 18, 2024 •
edited
Loading

Changes:

image
Screen.Recording.2024-04-18.at.11.44.53.AM.mov

@shontzu-deriv shontzu-deriv mentioned this pull request Apr 18, 2024
Closed
@coveralls
Copy link

coveralls commented Apr 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8779282211

Details

  • 24 of 73 (32.88%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.1%) to 48.956%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/cfd/modals/TradeModal/TradeModal.tsx 0 7 0.0%
src/cfd/constants/constants.tsx 5 13 38.46%
src/cfd/screens/TradeScreen/MT5MobileRedirectOption.tsx 5 14 35.71%
src/utils/userBrowser.ts 2 13 15.38%
src/utils/mobileOsDetect.ts 1 15 6.67%
Totals Coverage Status
Change from base Build 8778447700: -1.1%
Covered Lines: 1342
Relevant Lines: 2234
💛 - Coveralls

hasan-deriv
hasan-deriv reviewed Apr 19, 2024
View reviewed changes
src/cfd/constants/constants.tsx Outdated Show resolved Hide resolved
src/cfd/screens/TradeScreen/MT5MobileRedirectOption.tsx Outdated Show resolved Hide resolved
src/cfd/screens/TradeScreen/TradeScreen.tsx Outdated Show resolved Hide resolved
@shontzu-deriv
Copy link
Contributor Author

please review the new urlConfig file I created, this will be sent as a proposal to the BE

@github-actions GitHub Actions
Copy link

Preview Link: https://pr-111.traders-hub.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@thisyahlen-deriv thisyahlen-deriv merged commit f4dc114 into deriv-com:main Apr 22, 2024
5 checks passed
@shontzu-deriv shontzu-deriv changed the title [TRAH] shontzu/TRAH-3015/ui-for-seamless-MT5-mobile-login-integration [REFACTORING] shontzu/TRAH-3015/ui-for-seamless-MT5-mobile-login-integration May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amina-deriv amina-deriv amina-deriv approved these changes

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv approved these changes

@hasan-deriv hasan-deriv hasan-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shontzu-deriv @coveralls @amina-deriv @thisyahlen-deriv @hasan-deriv