-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Font render blocking #90
Conversation
Deploying traders-hub with Cloudflare Pages
|
Pull Request Test Coverage Report for Build 8715924219Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
261bbc3
to
01dc446
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see on your testlink this error:
Google advice to download fonts in index.html like this:
<link rel="preconnect" href="https://fonts.googleapis.com" />
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
<link
href="https://fonts.googleapis.com/css2?family=IBM+Plex+Sans:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;1,100;1,200;1,300;1,400;1,500;1,600;1,700&display=swap"
rel="stylesheet"
/>
Also I noticed we are using components from deriv-com/ui
and we uses the same font there (https://github.com/deriv-com/ui/blob/main/src/styles/abstracts/_variables.scss). In result we downloaded the same font 2 times (one time in index.html
and 2nd time in css
from deriv-com/ui
)
Preview Link: https://pr-90.traders-hub.pages.dev
|
Font's are render blocking resources as they are being called from CSS. Instead, we're calling it from index.html