-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement ADR-22: Per-subspace token factory #1141
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1141 +/- ##
==========================================
+ Coverage 80.80% 80.92% +0.11%
==========================================
Files 194 215 +21
Lines 17310 17972 +662
==========================================
+ Hits 13987 14543 +556
- Misses 2727 2821 +94
- Partials 596 608 +12
☔ View full report in Codecov by Sentry. |
@RiccardoM @manu0466 I have a question when implementing it, is it would be better that we fork the Something like:
I think it would be easier to update |
@dadamu I think forking here is unnecessary. We just need to add some checks that can be easily performed inside a custom |
@RiccardoM Thanks for the answer, will change to import |
@RiccardoM @manu0466 Unfortunately, In addition, Cosmwasm team decided to stop maintaining |
What features are you talking about? |
@RiccardoM Updating to 0.47.x, are many breaking changes, which leads the error when importing to desmos, say: Currently Cosmos-SDK version of the latest osmosis v15.1.0 is v0.46.10, we should wait for its upgrade. |
@dadamu What about implementing our token factory without relying on external implementations? And then we later change to replace that if we consider that to be worth. |
455394b
to
d56b577
Compare
cb85c53
to
a4a020d
Compare
It seems Updated: June 14, 2023, 11:41:00 UTC +0 |
89d8757
to
225e527
Compare
ae7d2c2
to
ace0f7c
Compare
b9994c0
to
e64f394
Compare
@RiccardoM Ready to review |
…abs/desmos into paul/DCD-316/token-factory-impl
Co-authored-by: Riccardo <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo <riccardo.montagnin@gmail.com>
Co-authored-by: Riccardo <riccardo.montagnin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 💯
Description
Deps: #1174
This PR implements ADR-22: Per-subspace token factory.
Closes: DCD-316
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change