Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare v7.2.0 #1345

Merged
merged 2 commits into from
Aug 8, 2024
Merged

chore: prepare v7.2.0 #1345

merged 2 commits into from
Aug 8, 2024

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Aug 8, 2024

Description

Closes: #XXXX
This PR prepares v7.2.0 including dependencies updates.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • New Features
    • Added support for the v7.2.0 upgrade, enhancing the app's upgrade capabilities.
  • Documentation
    • Updated the CHANGELOG to reflect new dependency versions and clarify version bumps.
  • Chores
    • Introduced new upgrade management logic to ensure compatibility with newer features.

@dadamu dadamu requested a review from a team as a code owner August 8, 2024 11:11
Copy link
Contributor

coderabbitai bot commented Aug 8, 2024

Walkthrough

The updates encompass a new version release (7.1.0) that includes dependency upgrades for cosmos-sdk and wasmvm, alongside the introduction of the v720 upgrade handler in the application. A new file outlines the upgrade's structure and methods, enhancing the app's upgrade capabilities while ensuring compatibility with existing modules. This release emphasizes improved dependency management and streamlined upgrade processes.

Changes

File Change Summary
CHANGELOG.md Updated to document dependency bumps for cosmos-sdk to v0.47.13 and wasmvm to v1.5.3; duplicate entry for cosmos-sdk.
app/upgrades.go Added registration of v720 upgrade in registerUpgradeHandlers method for enhanced upgrade capability.
app/upgrades/v720/upgrade.go Introduced Upgrade struct with methods for managing the v7.2.0 upgrade, including its handler and store upgrades.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant UpgradeManager

    User->>App: Initiate Upgrade
    App->>UpgradeManager: Process Upgrade v720
    UpgradeManager->>App: Execute Upgrade Logic
    App->>User: Confirm Upgrade Completion
Loading

Poem

🐇 In the meadow, changes bloom,
Upgrades dance, dispelling gloom.
New versions hop, dependencies cheer,
As the rabbit whispers, "Upgrades are here!"
With each leap, our app grows bright,
Embracing the future, oh what a sight! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 684d643 and d9b8d8a.

Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • app/upgrades.go (1 hunks)
  • app/upgrades/v720/upgrade.go (1 hunks)
Additional comments not posted (9)
app/upgrades.go (2)

6-6: Import addition looks good.

The import for v720 is consistent with existing imports for previous versions.


13-13: Registration of v720 upgrade handler is correct.

The addition of the v720 upgrade handler follows the same pattern as previous versions, ensuring consistency.

app/upgrades/v720/upgrade.go (7)

1-10: File structure and imports are appropriate.

The file is well-organized, and the necessary imports are included.


12-14: Interface implementation is correct.

The Upgrade struct correctly implements the upgrades.Upgrade interface.


16-20: Struct definition is clear and concise.

The Upgrade struct is defined with the necessary fields for module management and configuration.


22-28: Constructor function is well-implemented.

NewUpgrade function correctly initializes and returns an Upgrade instance.


30-33: Upgrade name is correctly set.

The Name method returns the expected version string for the upgrade.


35-41: Handler function is implemented correctly.

The Handler method returns an upgrade handler that runs migrations without requiring additional logic, which is appropriate for this upgrade.


43-46: Store upgrades method is correctly implemented.

The StoreUpgrades method returns an empty StoreUpgrades struct, indicating no store changes are needed.

Comment on lines +5 to +8
## Version 7.1.0
### Dependencies
- ([\#1323](https://github.com/desmos-labs/desmos/pull/1343)) Bumped `cosmos-sdk` to `v0.47.13`
- ([\#1324](https://github.com/desmos-labs/desmos/pull/1344)) Bumped `wasmvm` to `v1.5.3`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate entry in dependencies section.

There is a duplicate entry for the cosmos-sdk version bump. Ensure this is intentional or remove the duplicate.

Copy link

github-actions bot commented Aug 8, 2024

👀 Docs preview available here: https://66b4b1ada5620fef5123ab26--desmos-docs.netlify.app

@dadamu dadamu merged commit 0f7fec1 into master Aug 8, 2024
55 of 62 checks passed
@dadamu dadamu deleted the paul/prepare-v7.2.0 branch August 8, 2024 11:51
dadamu added a commit that referenced this pull request Aug 8, 2024
dadamu added a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant