From 1c6c4e0183d51c8a6a5abd737c643c86e0986e42 Mon Sep 17 00:00:00 2001 From: Bradley White <14679271+devbww@users.noreply.github.com> Date: Mon, 25 Apr 2022 14:42:34 -0400 Subject: [PATCH] fix: temporarily disable google/cloud/storagetransfer on macOS See #8785 about a name clash on `UID_MAX` from ``. --- CHANGELOG.md | 7 +++++++ google/cloud/storagetransfer/BUILD.bazel | 5 +++++ google/cloud/storagetransfer/CMakeLists.txt | 10 ++++++++++ 3 files changed, 22 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6256cf75c460..a92eb430c241 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -90,6 +90,13 @@ noted, the APIs in these libraries are stable, and are ready for production use. necessarily depends on these implementation details. We updated the [mocking examples][storage-mocking-link] to guide you in changing any tests. +### [Storage Transfer Service](https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/storagetransfer/README.md) + +**BREAKING CHANGES** + +The library has been disabled on macOS due to a protobuf naming clash. See +[#8785](https://github.com/googleapis/google-cloud-cpp/issues/8785) for details. + ### New Libraries We are introducing 2 new client libraries for GCP services. While we do not diff --git a/google/cloud/storagetransfer/BUILD.bazel b/google/cloud/storagetransfer/BUILD.bazel index 505b21b30dca..ea58e39fb3b9 100644 --- a/google/cloud/storagetransfer/BUILD.bazel +++ b/google/cloud/storagetransfer/BUILD.bazel @@ -34,6 +34,11 @@ cc_library( include = [HEADER_GLOB], exclude = [MOCK_HEADER_GLOB], ), + # TODO(#8785): Enable on macOS and windows. + target_compatible_with = select({ + "@platforms//os:macos": ["@platforms//:incompatible"], + "//conditions:default": [], + }), visibility = ["//:__pkg__"], deps = [ "//:common", diff --git a/google/cloud/storagetransfer/CMakeLists.txt b/google/cloud/storagetransfer/CMakeLists.txt index a9a4317954f3..5e49e309fa00 100644 --- a/google/cloud/storagetransfer/CMakeLists.txt +++ b/google/cloud/storagetransfer/CMakeLists.txt @@ -14,6 +14,16 @@ # limitations under the License. # ~~~ +# TODO(8785): Enable on macOS. +if (APPLE) + message( + WARNING + "Cannot build google/cloud/storagetransfer on Apple platforms." + " More details at https://github.com/googleapis/google-cloud-cpp/issues/8785 ." + ) + return() +endif () + include(GoogleapisConfig) set(DOXYGEN_PROJECT_NAME "Storage Transfer API C++ Client") set(DOXYGEN_PROJECT_BRIEF "A C++ Client Library for the Storage Transfer API")