Skip to content

Commit

Permalink
Remove II interface check exception (#2176)
Browse files Browse the repository at this point in the history
Due to breaking changes in the experimental API v2, we modified the
CI check for interface compatibility. Since the new interface has
now been published as the latest release, these exceptions are
no longer needed.
  • Loading branch information
frederikrothenberger committed Jan 8, 2024
1 parent 9db0005 commit 0714c0d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 101 deletions.
19 changes: 0 additions & 19 deletions .github/workflows/canister-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -891,27 +891,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
# we need the history for the tags, but we don't need the files (except for the GitHub workflows / actions)
# --> sparse checkout of only the needed things
fetch-depth: 0
sparse-checkout: |
src/internet_identity/internet_identity.did
.github
.didc-release
allowed_breaking_change.patch
sparse-checkout-cone-mode: false
- uses: ./.github/actions/setup-didc
- name: "Check canister interface compatibility"
run: |
release="release-2023-12-15"
# undo the breaking changes that we _explicitly_ made
# remove after the next release
# if we accidentally introduced other breaking changes, the patch would no longer apply / fix them
# making this job fail.
if [ "$(git describe --tags --match="release-[0-9-]*" HEAD --abbrev=0)" == "$release" ]; then
echo "Rolling back intentionally made breaking changes $release"
git apply allowed_breaking_change.patch
fi
curl -sSL https://github.com/dfinity/internet-identity/releases/latest/download/internet_identity.did -o internet_identity_previous.did
didc check src/internet_identity/internet_identity.did internet_identity_previous.did
82 changes: 0 additions & 82 deletions allowed_breaking_change.patch

This file was deleted.

0 comments on commit 0714c0d

Please sign in to comment.