-
Notifications
You must be signed in to change notification settings - Fork 135
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Switch to dfinity/setup-dfx action (#2346)
This PR removes our local `setup-dfx` action and replaces it with the one maintained by the SDK team. This action has the advantage that it integrates with the new `dfxvm` and reads the desired dfx version from `dfx.json`. Adding the version there also aligns the dfx version used locally with the one on CI. The dfx version will be bumped to `0.18.0` in a follow-up commit. Side-note on CI runtime: the `dfinity/setup-dfx` does not use caching (unlike our version) but still takes only about 4s to complete. Given that we get rid of some complexity that way, I think the 3s are worth it. Also, because the `dfinity/setup-dfx` action is not yet properly published on the market place (there is an open issue for that [here](dfinity/setup-dfx#8)) a specific commit is pinned instead.
- Loading branch information
1 parent
056aee3
commit b419b80
Showing
4 changed files
with
5 additions
and
37 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,5 +27,6 @@ | |
"packtool": "" | ||
} | ||
}, | ||
"dfx": "0.15.3", | ||
"version": 1 | ||
} |