Clean up and clarify authz landing #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the "authorization" landing page (i.e. when authenticating to a dapp) in a few ways: * The dapps teaser/header is removed as it caused issues on small windows (CTA not in view) * The copy is clarified * The alt origin dropdown is changed to appear upon clicking the dapp domain
peterpeterparker
approved these changes
May 8, 2023
| "to_continue_to": "to connect to", | ||
| "is_alternative_of": "is an alternative domain of", | ||
| "auth_same_identity": "and you will be authenticated to both with the same identity.", | ||
|
|
||
| "first_time_create": "Securely connect to dapps on the Internet Computer", | ||
| "first_time_create": "Securely connect with Internet Identity", |
There was a problem hiding this comment.
asked my self if it should be phrased "Securely connect with an Internet Identity" so just sharing, just in case
There was a problem hiding this comment.
Hm, I think it depends whether the product is also still called Internet Identity...
There was a problem hiding this comment.
Product did consider it, then went for the current wording
| @@ -1990,7 +1990,7 @@ a:hover, | |||
| } | |||
|
|
|||
| .c-chasm__arrow { | |||
| margin: auto; | |||
| margin-left: calc(1.25 * var(--rs-card-bezel)); | |||
There was a problem hiding this comment.
side note:
@meodai 1.25 * var(--rs-card-bezel) comes few times in the CSS file, four exactly, should a variable be extracted?
frederikrothenberger
approved these changes
May 8, 2023
| "to_continue_to": "to connect to", | ||
| "is_alternative_of": "is an alternative domain of", | ||
| "auth_same_identity": "and you will be authenticated to both with the same identity.", | ||
|
|
||
| "first_time_create": "Securely connect to dapps on the Internet Computer", | ||
| "first_time_create": "Securely connect with Internet Identity", |
There was a problem hiding this comment.
Hm, I think it depends whether the product is also still called Internet Identity...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the "authorization" landing page (i.e. when authenticating to a dapp) in a few ways: