Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment for dropdown trigger in e2e test #1583

Merged
merged 3 commits into from
May 12, 2023
Merged

Update comment for dropdown trigger in e2e test #1583

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
322b8d0
docs: update comment for dropdown trigger in e2e test as it requires …
peterpeterparker May 11, 2023
c42b524
Merge branch 'main' into docs/test-comment-dropdown
peterpeterparker May 11, 2023
2363177
Merge branch 'main' into docs/test-comment-dropdown
peterpeterparker May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/frontend/src/test-e2e/views.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ export class MainView extends View {
await this.browser.execute(
"window.scrollTo(0, document.body.scrollHeight)"
);
// Ensure the dropdown is open by hovering/clicking (clicking is needed for mobile)
// Open the dropdown by clicking on the trigger button
await this.browser
.$(`button.c-dropdown__trigger[data-device="${deviceName}"]`)
.click();
Expand All @@ -280,7 +280,7 @@ export class MainView extends View {
await this.browser.execute(
"window.scrollTo(0, document.body.scrollHeight)"
);
// Ensure the dropdown is open by hovering/clicking (clicking is needed for mobile)
// Open the dropdown by clicking on the trigger button
await this.browser
.$(`button.c-dropdown__trigger[data-device="${deviceName}"]`)
.click();
Expand Down Expand Up @@ -310,7 +310,7 @@ export class MainView extends View {
await this.browser.execute(
"window.scrollTo(0, document.body.scrollHeight)"
);
// Ensure the dropdown is open by hovering/clicking (clicking is needed for mobile)
// Open the dropdown by clicking on the trigger button
await this.browser
.$(`button.c-dropdown__trigger[data-device="${deviceName}"]`)
.click();
Expand All @@ -336,7 +336,7 @@ export class MainView extends View {
}

async remove(deviceName: string): Promise<void> {
// Ensure the dropdown is open by hovering/clicking (clicking is needed for mobile)
// Open the dropdown by clicking on the trigger button
await this.browser
.$(`button.c-dropdown__trigger[data-device="${deviceName}"]`)
.click();
Expand All @@ -349,7 +349,7 @@ export class MainView extends View {
}

async reset(deviceName: string): Promise<void> {
// Ensure the dropdown is open by hovering/clicking (clicking is needed for mobile)
// Open the dropdown by clicking on the trigger button
await this.browser
.$(`button.c-dropdown__trigger[data-device="${deviceName}"]`)
.click();
Expand Down