Scroll to reset protected recovery phrase to fix flaky test #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
changed the title
peterpeterparker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tests are currently flaky. They work locally but often fails in the CI. By comparing the tests I noticed that two of the six e2e tests for the recovery phrase - the two that failed - were performed without the viewport being scrolled first.
This PR copy paste the scroll action and comment which per extension fix the test for the CI.
Not sure if the root cause is the introduction of dapp explorer, new design or the fact that webdriver io felt more confortable with a hover rather tha a click at the edge of the viewport.