Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import identity card image from vite #1655

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Import identity card image from vite #1655

merged 1 commit into from
Jun 1, 2023

Conversation

nmattia
Copy link
Collaborator

@nmattia nmattia commented Jun 1, 2023

This removes the identity card image from the assets directory and instead creates a direct import, meaning we let vite deal with setting the correct BASE_URL. The image is now also closer to where it's used in the code.

This removes the identity card image from the assets directory and
instead creates a direct import, meaning we let `vite` deal with setting
the correct BASE_URL. The image is now also closer to where it's used in
the code.
@nmattia nmattia marked this pull request as ready for review June 1, 2023 09:58
Copy link
Member

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nmattia nmattia added this pull request to the merge queue Jun 1, 2023
Merged via the queue into main with commit 3417ba0 Jun 1, 2023
@nmattia nmattia deleted the nm-id-card-noasset branch June 1, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants