Update copy on identity & phrase creation #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies the copy & removes the bullet points, since the paragraphs were not actually lists.
nmattia
changed the title
meodai
reviewed
Jun 12, 2023
| @@ -1631,6 +1631,7 @@ by all browsers (FF is missing) */ | |||
|
|
|||
| .c-list--bulleted { | |||
| padding-left: var(--rs-list-bullet-space); | |||
| margin-top: 1em; /* match paragraph margin */ | |||
There was a problem hiding this comment.
I would add something like: --rs-list-stack to the tokens in:root
and then reuse it here: margin-top: var(--rs-list-item-stack)
There was a problem hiding this comment.
so actually we already have one, but it's a bit smaller that the 1em the paragraphs use. I'll leave it as is for now but feel free to have a look!
meodai
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies the copy & removes the bullet points, since the paragraphs were not actually lists.