Make recovery info page less scary #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the recovery info page (shown before recovery creation):
* The "warning" icon is now an "info" icon (red -> purple)
* The text ("SECURITY WARNING") is a bit softer ("Learn about
recovery")
nmattia
force-pushed
the
nm-learn-about-recovery
branch
from
f8a9225
to
9aee31d
Compare
nmattia
commented
Jun 13, 2023
There was a problem hiding this comment.
I feel like the icon could be lighter, i.e. maybe use the outline instead of a filled icon
meodai
reviewed
Jun 13, 2023
| @@ -698,6 +701,12 @@ a:hover, | |||
| .c-icon--ok { | |||
| --onBgc: var(--rc-positive); | |||
| } | |||
| .c-icon--info__flipped { | |||
There was a problem hiding this comment.
__ would be a child in BEM. I would create a separate class called .c-icon--inverted that combines with any icon class. But since it looks like info is always flipped, it might not need a modifier? So just c-icon--info, makes sense?
| @@ -256,6 +256,21 @@ export const infoIcon = html` | |||
| </svg> | |||
| `; | |||
|
|
|||
| export const infoIconNaked = html` | |||
There was a problem hiding this comment.
not sure what is meant by Naked would be super nice to have a comment or something here.
meodai
approved these changes
Jun 13, 2023
meodai
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the recovery info page (shown before recovery creation):