Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus identity field on recovery #1693

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Focus identity field on recovery #1693

merged 1 commit into from
Jun 15, 2023

Conversation

nmattia
Copy link
Collaborator

@nmattia nmattia commented Jun 15, 2023

Previously, the identity number was just another word in the recoery word grid, so in order to focus it we just focused the first word (during recovery & new phrase confirmation).

Now that the identity is a different field, it is that new field that should be focused; not the first BIP39 word.

Previously, the identity number was just another word in the recoery
word grid, so in order to focus it we just focused the first word
(during recovery & new phrase confirmation).

Now that the identity is a different field, it is that new field that
should be focused; not the first BIP39 word.
@nmattia nmattia marked this pull request as ready for review June 15, 2023 11:53
@nmattia nmattia requested a review from meodai June 15, 2023 11:53
Copy link
Collaborator

@meodai meodai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmattia nmattia added this pull request to the merge queue Jun 15, 2023
@nmattia nmattia removed this pull request from the merge queue due to a manual request Jun 15, 2023
@nmattia nmattia merged commit 4393fee into main Jun 15, 2023
@nmattia nmattia deleted the nm-identity-focus branch June 15, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants