Send Slack notification on RC deploy fail #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the RC deployment to notify the team if the deployment failed. This is similar to what we do for other scheduled jobs (node updated, rust update, etc).
przydatek
approved these changes
Jun 15, 2023
|
|
||
| # Since the this is a scheduled job, a failure won't be shown on any | ||
| # PR status. To notify the team, we send a message to our Slack channel on failure. | ||
| - name: Notify Slack on failure |
There was a problem hiding this comment.
nit: not sure whether this is relevant, but maybe: most of the other - name: entries above are in quotation marks (except for the one in line 79), so maybe use them also here?
There was a problem hiding this comment.
That's right! We use both somewhat inconsistently, as YAML allows for both. Other "Notify Slack on failure" entries use this style (without quotes), I just copy/pasted one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the RC deployment to notify the team if the deployment failed. This is similar to what we do for other scheduled jobs (node updated, rust update, etc).