Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Slack notification on RC deploy fail #1698

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Send Slack notification on RC deploy fail #1698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/deploy-rc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,12 @@ jobs:
Internet Identity release candidate
RC link: https://${{ env.ii_canister_id }}.ic0.app
test app: https://${{ env.testnet_app_canister_id }}.ic0.app

# Since the this is a scheduled job, a failure won't be shown on any
# PR status. To notify the team, we send a message to our Slack channel on failure.
- name: Notify Slack on failure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not sure whether this is relevant, but maybe: most of the other - name: entries above are in quotation marks (except for the one in line 79), so maybe use them also here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right! We use both somewhat inconsistently, as YAML allows for both. Other "Notify Slack on failure" entries use this style (without quotes), I just copy/pasted one.

uses: ./.github/actions/slack
if: ${{ failure() }}
with:
WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
MESSAGE: "RC deployment failed"