Factor out get_signature and add it to canister_sig_util #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikrothenberger
approved these changes
Dec 13, 2023
|
|
||
| let witness_hash = witness.digest(); | ||
| let root_hash = sig_map.root_hash(); | ||
| if witness_hash != root_hash { |
There was a problem hiding this comment.
Does this check (still) make sense? We rehash the pruned witness tree every time, but if it did not match the (unpruned) signature map root hash, we would simply have a bug in our implementation. I wonder if this is really best addressed by wasting resources in production, or if we should rather have better tests (unless we're already sufficiently covered).
Honestly, I think we should remove it here.
There was a problem hiding this comment.
| if witness_hash != root_hash { | ||
| return Err(format!( | ||
| "internal error: signature map computed an invalid hash tree, witness hash is {}, root hash is {}", | ||
| hex::encode(witness_hash), |
There was a problem hiding this comment.
You could also get rid of the hex dependency if you didn't have this check 😉
przydatek
commented
Dec 13, 2023
|
|
||
| let witness_hash = witness.digest(); | ||
| let root_hash = sig_map.root_hash(); | ||
| if witness_hash != root_hash { |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out
get_signature, which is used in canisters that create canister signatures, and add the corresponding functionality tocanister_sig_util-crate (as functionget_signature_as_cbor).🟡 Some screens were changed