Use correct node version in clean build #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clean build was using whatever node version was in the environment. This updates the `check-build` action to use the `setup-node` action, so that it uses the expected node version. A version check is added to the build script. On CI, this aborts the build. Not on CI, this issues a warning. The clean build reproducibility checks are also re-enabled. The reproducibility issues were caused by differences in the compressed assets. It looks like node statically links zlib, and it looks like the zlib version from the GHA environment's node differs from the one in our docker setup (set through `.node-version`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clean build was using whatever node version was in the environment. This updates the
check-buildaction to use thesetup-nodeaction, so that it uses the expected node version.A version check is added to the build script. On CI, this aborts the build. Not on CI, this issues a warning.
The clean build reproducibility checks are also re-enabled. The reproducibility issues were caused by differences in the compressed assets. It looks like node statically links zlib, and it looks like the zlib version from the GHA environment's node differs from the one in our docker setup (set through
.node-version).