Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct node version in clean build #2168

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Commits on Jan 4, 2024

  1. Use correct node version in clean build

    The clean build was using whatever node version was in the environment.
    This updates the `check-build` action to use the `setup-node` action, so
    that it uses the expected node version.
    
    A version check is added to the build script. On CI, this aborts the
    build. Not on CI, this issues a warning.
    
    The clean build reproducibility checks are also re-enabled. The
    reproducibility issues were caused by differences in the compressed
    assets. It looks like node statically links zlib, and it looks like the
    zlib version from the GHA environment's node differs from the one in our
    docker setup (set through `.node-version`).
    nmattia committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    72166f1 View commit details
    Browse the repository at this point in the history