Update README.md #2210
Closed
Update README.md #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
reviewed
Jan 18, 2024
Comment on lines
+53
to
+54
| "candid": "https://github.com/dfinity/internet-identity/releases/latest/download/internet_identity.did", | ||
| "wasm": "https://github.com/dfinity/internet-identity/releases/latest/download/internet_identity_dev.wasm.gz", |
There was a problem hiding this comment.
This is not ideal as this doesn't pin the release. An alternative would be to update the README on new releases!
There was a problem hiding this comment.
why do we need to pin the release in the readme?
There was a problem hiding this comment.
people copy/paste it and then they get different versions depending on when they first ran their first dfx command; it's just best practice to pin
There was a problem hiding this comment.
Added an automatic update: #2226
|
Closing because of recently added automation to update the README; feel free to reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.