Fix race condition in devserver #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The devserver handles proxying requests to canisters. The previous implementation used a single `http-proxy` Proxy object, where the handlers were rewritten for each new async request. The caused issues with concurrent request, where a new request might set up new handlers for an in-flight request. This drops the dependency on `http-proxy` and instead proxies the request using `undici` (existing transivite dep through Vite). The forwarding code is also moved to the utils module.
frederikrothenberger
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devserver handles proxying requests to canisters. The previous implementation used a single
http-proxyProxy object, where the handlers were rewritten for each new async request.The caused issues with concurrent request, where a new request might set up new handlers for an in-flight request.
This drops the dependency on
http-proxyand instead proxies the request usingundici(existing transivite dep through Vite).The forwarding code is also moved to the utils module.