Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up release job #2216

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Clean up release job #2216

merged 1 commit into from
Jan 22, 2024

Conversation

nmattia
Copy link
Collaborator

@nmattia nmattia commented Jan 19, 2024

This updates the release job in the canister-tests workflow:

  • The release notes are built on every CI run instead on only on release (though they are uploaded only on release)
  • The release steps are all given names for legibility
  • A new step is added that simply prints the notes
  • Some comments are updated to clarify what's happening in the note generation

🟡 Some screens were changed

This updates the release job in the canister-tests workflow:
* The release notes are built on every CI run instead on only on release
  (though they are _uploaded_ only on release)
* The release steps are all given names for legibility
* A new step is added that simply prints the notes
* Some comments are updated to clarify what's happening in the note
  generation
Copy link
Member

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nmattia nmattia added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit 118c847 Jan 22, 2024
57 checks passed
@nmattia nmattia deleted the nm-release-always branch January 22, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants