Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up release job #2216

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Clean up release job #2216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/actions/release/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ do
if [ -z "$filename" ]; then continue; fi
>&2 echo working on asset "$filename"

# Find out the Job ID
# For each asset, find the ID of the job that created the asset and find the step that
# printed the asset's checksum (will be linked in the notes)
#
# XXX: Unfortunately GitHub actions doesn't give us a way to find out the Job ID explicitely.
# Instead, we find the job name that includes "$filename" without the .wasm or .wasm.gz extension and assume that's the Job ID.
# This works because our jobs contain the filename without extension
Expand Down
27 changes: 17 additions & 10 deletions .github/workflows/canister-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,46 +716,47 @@ jobs:
run: scripts/deploy-archive --wasm archive.wasm.gz --canister-id fgte5-ciaaa-aaaad-aaatq-cai --network ic


# This ... releases
# This prepares all the files necessary for a release (all flavors of Wasm, release notes).
# On release tags, a new release is created and the assets are uploaded.
release:
runs-on: ubuntu-latest
if: startsWith(github.ref, 'refs/tags/release-')
needs: [docker-build-internet_identity_production, docker-build-archive]

steps:
- uses: actions/checkout@v3

- name: 'Download wasm.gz'
- name: 'Download test build'
uses: actions/download-artifact@v4
with:
name: internet_identity_test.wasm.gz
path: .

- name: 'Download wasm.gz'
- name: 'Download dev build'
uses: actions/download-artifact@v4
with:
name: internet_identity_dev.wasm.gz
path: .

- name: 'Download wasm.gz'
- name: 'Download production build'
uses: actions/download-artifact@v4
with:
name: internet_identity_production.wasm.gz
path: .

- name: 'Download wasm.gz'
- name: 'Download archive'
uses: actions/download-artifact@v4
with:
name: archive.wasm.gz
path: .

- name: 'Download wasm.gz'
- name: 'Download issuer'
uses: actions/download-artifact@v4
with:
name: vc_demo_issuer.wasm.gz
path: .

- uses: actions/github-script@v6
- name: 'Get GHA job IDs'
uses: actions/github-script@v6
id: pipeline-jobs
with:
script: |
Expand All @@ -770,7 +771,8 @@ jobs:
html_url: job.html_url}
});

- uses: actions/github-script@v6
- name: 'Get latest release'
uses: actions/github-script@v6
id: latest-release-tag
with:
result-encoding: string
Expand All @@ -781,7 +783,8 @@ jobs:
# it on its own, GitHub is really bad at figuring which tag to use as the previous tag (for
# listing contributions since).
# https://github.com/github/feedback/discussions/5975
- uses: actions/github-script@v6
- name: 'Generate CHANGELOG'
uses: actions/github-script@v6
id: changelog
with:
result-encoding: string
Expand Down Expand Up @@ -817,7 +820,11 @@ jobs:
changelog: ${{ steps.changelog.outputs.result }}
workflow_jobs: ${{ steps.pipeline-jobs.outputs.result }}

- name: Release notes
run: cat ${{ steps.prepare-release.outputs.notes-file }}

- name: Publish release
if: startsWith(github.ref, 'refs/tags/release-')
run: |
./scripts/release \
--tag ${{ github.ref }} \
Expand Down