Remove traps from authenticated_anchor_operation #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the traps from the authenticated_anchor_operation helper, which allows to add proper errors to `identity_metadata_replace`.
|
Can you briefly explain why the API breakage is fine? |
The API breakage is fine because it is in the API v2 only, which is labeled as experimental. Unfortunately, there is no clean way to mark parts of the API as experimental that would be natively understood by the candid check. |
przydatek
approved these changes
Jan 23, 2024
|
@przydatek: I added the context to the errors. Could you please take another look? I will then also do another PR to also adapt the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the traps from the authenticated_anchor_operation helper, which allows to add proper errors to
identity_metadata_replace.I will do a follow-up PR to move the authentication helpers and error mappers out of the
main.rsfile to keep it focused on the endpoints.