Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README release update sed command #2227

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix README release update sed command #2227

merged 1 commit into from
Jan 23, 2024

Conversation

nmattia
Copy link
Collaborator

@nmattia nmattia commented Jan 23, 2024 •
edited
Loading

This changes the sed command to use | separators instead of /, since / often occurs and branch (and hence: ref) names.

@nmattia
Fix README release update sed command
fa9053c 
This changes the `sed` command to use `:` separators instead of `/`,
since `/` often occurs and branch (and hence: ref) names.
frederikrothenberger
frederikrothenberger approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!
The separator is | not : now, right?

@nmattia
Copy link
Collaborator Author

nmattia commented Jan 23, 2024

The separator is | not : now, right?

Damn right! Started with : then realized it was not unlikely to occur in a branch name and forgot to update the commit message. Good catch!

@nmattia nmattia added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit c926cf9 Jan 23, 2024
63 checks passed
@nmattia nmattia deleted the nm-fix-sed branch January 23, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmattia @frederikrothenberger