Clean up test-app authentication #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the dependency on auth-client for greater flexibility in tests, removes an unused button (signout) from the test app, and makes makes the message-display function a bit more robuest/clear. This will allow us to be more flexible when testing out new APIs, since we now fully control the authentication flow in the test.
nmattia
force-pushed
the
nm-no-auth-client
branch
from
e527691
to
69d9199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency on auth-client for greater flexibility in tests, removes an unused button (signout) from the test app, and makes makes the message-display function a bit more robuest/clear.
This will allow us to be more flexible when testing out new APIs, since we now fully control the authentication flow in the test.
🟡 Some screens were changed