Remove low-level stable memory tests #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes storage unit tests as well as II integration tests that make too strong assumptions about the underlying memory layout. These tests were very useful at the time when we were still operating manually on the raw memory and also during the migration to managed memory to make sure that all the bits and bytes end up exactly where we want them to. Now, that the memory manager is well established, these tests are a hindrance to fully using its capabilities. As such, it is now acceptable to remove these tests and rely on the stable-structures crate itself being thoroughly tested.
przydatek
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes storage unit tests as well as II integration tests that make too strong assumptions about the underlying memory layout. These tests were very useful at the time when we were still operating manually on the raw memory and also during the migration to managed memory to make sure that all the bits and bytes end up exactly where we want them to.
Now, that the memory manager is well established, these tests are a hindrance to fully using its capabilities. As such, it is now acceptable to remove these tests and rely on the stable-structures crate itself being thoroughly tested.