Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve HACKING.md #2273

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Improve HACKING.md #2273

merged 3 commits into from
Feb 15, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Feb 15, 2024 •
edited by github-actions bot
Loading

Fix a command of the HACKING.md

🟡 Some screens were changed

@lmuntaner
Copy link
Collaborator Author

@frederikrothenberger @nmattia please review

@lmuntaner lmuntaner changed the title Fix: Improve hacking.md Improve hacking.md Feb 15, 2024
@lmuntaner lmuntaner changed the title Improve hacking.md Improve HACKING.md Feb 15, 2024
nmattia
nmattia approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Might want to point out that this doesn't work in e.g. Safari though

@lmuntaner
Copy link
Collaborator Author

Thanks! Might want to point out that this doesn't work in e.g. Safari though

The query param doesn't work in safari either. At least for me.

@peterpeterparker
Copy link
Member

peterpeterparker commented Feb 15, 2024 •
edited
Loading

Wait, most people do not use dfx nns install - i.e. most developers use 4943!

NVM refresh display that you stick to this port.

@lmuntaner lmuntaner added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit 2a6213c Feb 15, 2024
63 checks passed
@lmuntaner lmuntaner deleted the 02-15-Fix_Improve_hacking.md branch February 15, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger left review comments

@nmattia nmattia nmattia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lmuntaner @peterpeterparker @nmattia @frederikrothenberger