Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate stable memory tests to v8 #2303

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Migrate stable memory tests to v8 #2303

merged 1 commit into from
Feb 26, 2024

Conversation

frederikrothenberger
Copy link
Member

@frederikrothenberger frederikrothenberger commented Feb 26, 2024 •
edited by github-actions bot
Loading

This PR migrates all of the stable memory back-up tests to storage layout v8.

@frederikrothenberger
Migrate stable memory tests to v8
b56efb4 
This PR migrates all of the stable memory back-up tests to storage
layout v8.
przydatek
przydatek approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
nit: I know we have in README.md instructions on how to generate test files in general, but afaik we don't have specific information about each of the test files -- given that you've now have "refreshed" the files and have that knowledge up-to-date, maybe it would make sense to add to README.md a list of the files with a short description?

@frederikrothenberger
Copy link
Member Author

LGTM, thanks! nit: I know we have in README.md instructions on how to generate test files in general, but afaik we don't have specific information about each of the test files -- given that you've now have "refreshed" the files and have that knowledge up-to-date, maybe it would make sense to add to README.md a list of the files with a short description?

Thanks, I'll update the readme in a separate PR. 👍

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit 27eaeb4 Feb 26, 2024
63 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/remove-v7 branch February 26, 2024 13:14
@frederikrothenberger
Copy link
Member Author

For the documentation: #2306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przydatek przydatek przydatek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikrothenberger @przydatek