Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HeaderField where applicable #2310

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Use HeaderField where applicable #2310

merged 1 commit into from
Feb 27, 2024

Conversation

nmattia
Copy link
Collaborator

@nmattia nmattia commented Feb 26, 2024 •
edited by github-actions bot
Loading

A couple of signatures were using (String, String) instead of the more appropriate type alias HeaderField = (String, String).

@nmattia
Use HeaderField where applicable
de427b6 
A couple of signatures were using `(String, String)` instead of the more
appropriate type alias `HeaderField = (String, String)`.
frederikrothenberger
frederikrothenberger approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nmattia nmattia added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 03ce332 Feb 27, 2024
63 checks passed
@nmattia nmattia deleted the nm-header-field branch February 27, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmattia @frederikrothenberger