Add support for persistent state in separate virtual memory #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for the storage layout `v9` which keeps the persistent state in a separate virtual memory. The PR does _not_ include any migration. Existing II installations will keep layout `v8`.
frederikrothenberger
force-pushed
the
frederik/move-config
branch
from
63abcb9
to
ace8b62
Compare
| @@ -145,7 +146,7 @@ pub const MAX_ENTRIES: u64 = (MAX_MANAGED_WASM_PAGES - BUCKET_SIZE_IN_PAGES as u | |||
|
|
|||
| pub type Salt = [u8; 32]; | |||
|
|
|||
| type ArchiveBufferMemory<M> = RestrictedMemory<VirtualMemory<RestrictedMemory<M>>>; | |||
| type SingleBucketMemory<M> = RestrictedMemory<VirtualMemory<RestrictedMemory<M>>>; | |||
There was a problem hiding this comment.
It would be cleaner to wrap the underlying memory such that:
- the memory is guaranteed to be limited to a single bucket
- the memory cannot be written to
However, I'll do this in a separate PR.
przydatek
approved these changes
Feb 28, 2024
| ii_canister | ||
| } | ||
|
|
||
| fn ii_canisters_under_test( |
| @@ -29,16 +29,16 @@ fn should_report_max_number_of_entries_for_256gb() { | |||
| } | |||
|
|
|||
| #[test] | |||
| fn should_serialize_header_v8() { | |||
| fn should_serialize_header_v9() { | |||
There was a problem hiding this comment.
nit: shouldn't we still keep the test for v8? (i.e. add a new one for v9)
There was a problem hiding this comment.
New storage is now automatically initialized in v9. The ability to initialize v8 is removed.
Compatibility with existing v8 storage is tested in the (unchanged) should_recover_header_from_memory_v8 test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the storage layout
v9which keeps the persistent state in a separate virtual memory.The PR does not include any migration. Existing II installations will keep layout
v8.