Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead-end in device add flow #2338

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

frederikrothenberger
Copy link
Member

@frederikrothenberger frederikrothenberger commented Mar 6, 2024

This PR fixes a dead end where users would end up stuck after adding a new passkey to an identity from the sign-in screen.

Note: This PR does not yet include the new confirmation screens as per figma. This will be done separately.


🟡 Some screens were changed

This PR fixes a dead end where users would end up stuck after adding a
new passkey to an identity from the sign-in screen.

Note: This PR does not yet include the new confirmation screens as per
figma. This will be done separately.
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not yet 100% onboarded here, but this looks good and it's tested.

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit 736392d Mar 7, 2024
63 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/fix-hang branch March 7, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants